| passing_by |
| Posted: 2013-08-27 16:13:58 |
|
|
Occasional visitor
Posts: 48
Member since:
2013-05-05 19:13:03 |
In hvl_mixchunk(), courtesy of eightbitbubsy.
if (a<-0x8000) a=-0x8000;
if (a> 0x7FFF) a= 0x7FFF;
if (b<-0x8000) b=-0x8000;
if (b> 0x7FFF) b= 0x7FFF;
*(int16 *)buf1 = a;
*(int16 *)buf2 = b;
|
Fixes nasty ear rape when mixgain is too high.
http://dl.dropboxusercontent.com/u/16644842/hvl/no_note.PNG
Note previewing for this instrument is broken, due to lack of note. It seems to play notes in some odd scale.
On regular playback, it's ok.
Note preview sometimes refuses to work(usually when switching between mpt and hively), requiring app restart. |
| Xeron |
| Posted: 2013-09-03 17:14:20 |
|
|
Supreme Being
Posts: 448
Member since:
2006-12-13 11:34:00 |
The first fix I will apply to the standalone replayer, but not the tracker.
I think the ear rape is a good indicator that the composer needs to click autogain, or tone it down manually, so that they save the hvl mod with a gain value that won't clip when you play it back in the replayer.
The latter isn't really a bug; its undefined behaviour. What, exactly, is the tracker supposed to do in that case?
AHX forever! |
| Xeron |
| Posted: 2013-09-03 17:15:48 |
|
|
Supreme Being
Posts: 448
Member since:
2006-12-13 11:34:00 |
The third one... well.. I don't know what to say. It always works on the Amiga, so its most likely something to do with SDL on your system.
AHX forever! |
| Xeron |
| Posted: 2013-09-06 11:47:02 |
|
|
Supreme Being
Posts: 448
Member since:
2006-12-13 11:34:00 |
BTW, would you be interested in commit access on google code?
AHX forever! |
| passing_by |
| Posted: 2013-09-11 17:51:20 |
|
|
Occasional visitor
Posts: 48
Member since:
2013-05-05 19:13:03 |
Xeron said:
BTW, would you be interested in commit access on google code? |
yus |
| Xeron |
| Posted: 2013-09-12 13:02:19 |
|
|
Supreme Being
Posts: 448
Member since:
2006-12-13 11:34:00 |
Do you have a google account associated with the email address you used to sign up to this forum, or do you want me to use a different one?
Feel free to email me the one to use if you don't want to post it to the forum :)
AHX forever! |
| passing_by |
| Posted: 2013-09-17 15:07:50 |
|
|
Occasional visitor
Posts: 48
Member since:
2013-05-05 19:13:03 |
Aaaand, sent. |
| Xeron |
| Posted: 2013-09-17 17:52:40 |
|
|
Supreme Being
Posts: 448
Member since:
2006-12-13 11:34:00 |
Welcome to the inner circle, Piss Master Plus ;-)
AHX forever! |
